fix: Remove erroneous pod_properties scoping from job definition variable attribute structure#45
Merged
bryantbiggs merged 1 commit intoterraform-aws-modules:masterfrom Jul 1, 2025
Conversation
bryantbiggs
changed the title
pod_properties scoping from job definition variable attribute structure
bryantbiggs
approved these changes
Jul 1, 2025
Member
bryantbiggs
left a comment
bryantbiggs
left a comment
There was a problem hiding this comment.
oof, thats not great - but thank you for fixing!
bryantbiggs
merged commit 7c8becf
into
terraform-aws-modules:master
7 of 8 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Jul 1, 2025
## [3.0.2](v3.0.1...v3.0.2) (2025-07-01) ### Bug Fixes * Remove erroneous `pod_properties` scoping from job definition variable attribute structure ([#45](#45)) ([7c8becf](7c8becf))
Member
|
This PR is included in version 3.0.2 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the way EKS pod properties are referenced in the aws_batch_job_definition resource in main.tf.
The module previously accessed attributes like dns_policy, host_network, image_pull_secrets, etc. from eks_properties.value.pod_properties, but according to the variable definition, these should be accessed directly from eks_properties.value.
Motivation and Context
This change is required to align the module implementation with the variable structure defined in variables.tf.
It solves errors like:
and similar errors for other attributes.
Breaking Changes
No breaking changes. This PR only corrects attribute references to match the documented variable structure.
How Has This Been Tested?
Used a minimal EKS job definition with pod properties and confirmed that the job definition is created successfully.
Verified that the AWS Console displays the "Pod Properties" tab and all configured properties.